Fix/replace deprecated budget method #1604
Open
+1
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1604 +/- ##
===========================================
- Coverage 93.53% 72.40% -21.13%
===========================================
Files 55 55
Lines 6357 6357
===========================================
- Hits 5946 4603 -1343
- Misses 411 1754 +1343 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cetagostini
approved these changes
Apr 2, 2025
There was a problem hiding this comment.
Hey @caiquefortunato thank you for the PR. Everything looks good 👍
|
Let's wait for the test to pass before merge but code looks okay! |
6 tasks
cetagostini
requested changes
Apr 2, 2025
|
|
||
| with pytest.raises(ValueError, match="noise_level must be a float"): | ||
| mmm_fitted.allocate_budget_to_maximize_response( |
There was a problem hiding this comment.
Sorry, reading this better. Here we are doing the wrong fix. We should:
- Replace all the suite (not only this test) to work with the new class.
- We need to test the same scenarios, meaning, you need to test
optimize budgetandsample_response_distribution - No parameters should be delete, the test should be handle differently.
- We need test for the method to be deprecated, and the new one. This because we still will hold the old method for at least one more release. So, best way should be to have test for both, and be sure non of them is doing something funny. IF we don't want to do this then we should deprecated already the old method. @williambdean Whats your take?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the test test_allocate_budget_to_maximize_response_bad_noise_level by replacing the usage of the deprecated method allocate_budget_to_maximize_response with the recommended optimize_budget method.
This aligns the codebase with the current API and avoids suppressing DeprecationWarnings, as discussed in issue #1598 and the feedback on PR #1603.
Related Issue
optimize_budgetmethod instead in tests #1598Checklist
pre-commit.ci autofixto auto-fix.📚 Documentation preview 📚: https://pymc-marketing--1604.org.readthedocs.build/en/1604/